-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving issues link checker #486
Resolving issues link checker #486
Conversation
Dear @cf-convention/info-mgmt team, this PR relates to long-standing issue with the link checker, see: #318 #320 This is a first step to fix the issues with the link checker when PR are made. The action is triggered when PR are open/re-open and
Please take a moment to review and let me know if this fits. If so, I will continue with the PR to incorporate the link check of the site at regular basis (i.e. cron job every Monday), or just we can merge this PR and open a new one PR for the that. |
PS: annotation of the PR with a comment with the link check report it's a challenge due to security issues with PR from forks. If PR are from same repo (not) forks then PR and ISSUE commenting it's possible. PS2: Checking links to GITHUB may raise and issue with the limit rate of GITHUB HTTP requests |
Hi Antonio,
I was recently adding some minor changes to this file, and noticed that there is actually very little markdown, and a lot of repetitive html links. I though that it maybe would be possible to generate this file dynamically during the build process. Something like a small [python] script looking for through the relevant |
@larsbarring I have made a new PR at #487 with your suggestion to refactor |
Dear Antonio @cofinoa Your work on this is very useful and much appreciated. Thanks! I would like to suggest that it makes the history of what's happened easier to follow if we keep to the practice of putting substantial comments in the issue, rather than PRs. That's because the issue is a continuous record of activity, whereas there can be lots of PRs, including comments on documents that aren't arranged serially. So I have copied the above comments from you and Lars into #318. Best wishes Jonathan |
No description provided.